[libcxx-commits] [libcxx] [libc++][hardening] Categorize more assertions. (PR #75918)

via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 21 17:01:22 PST 2023


EricWF wrote:

> > Are `_LIBCPP_ASSERT_INTERNAL` checks things that should only fail if our implementation is incorrect?
> 
> Yes, exactly.

Thanks for separating these out. We should consider if we want these, at all, at least in fully mature code. Have we ever seen these fire in the wild?

Also this change LGTM. Thanks (once fixing the bots of course).

https://github.com/llvm/llvm-project/pull/75918


More information about the libcxx-commits mailing list