[libcxx-commits] [libcxx] [ASan][libc++] Hotfix: String annotations stack frame size (PR #76192)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 21 15:18:39 PST 2023


https://github.com/ldionne commented:

Under what circumstances is this not optimized? Do you have a godbolt link or something like that?

In general, we are comfortable relying on some optimizations to produce decent code. I am a bit shocked that this doesn’t behave like we’d expect in all cases, and if that’s the case we may want to rethink how much we expect from the compiler, but I’d like to do it based on solid evidence to avoid cargo-culting everywhere in the code. There’s a lot of places where we expect the compiler to perform similar optimizations, so in theory this kind of “hardcoding of simplifications” applies to a wide range of places.

https://github.com/llvm/llvm-project/pull/76192


More information about the libcxx-commits mailing list