[libcxx-commits] [libcxx] [DRAFT][libc++][modules] Improves std.compat module. (PR #74945)

[Mark de Wever via libcxx-commits]

mordante wrote:

> > This patch is on hold. There are issues to get this working in our build infrastructure. For unrelated reasons to this patch there are some improvements I want to make in the infrastructure. I expect that that solves my issues with this patch too.
> 
> Got it. I was curious why it is problematic since I thought the cmake should handle that well.

I expected that too, but it didn't. The other issue is the test infrastructure using CMake is problematic for several reasons. The main reason to use CMake was the module partition per header. Since we changed that design we only have 2 modules to build. This can be done manually. The proof-of-concept I have removes about 200 lines of code and removes the CMake 3.26 requirement to test modules with libc++. (Users still need a new CMake when they want to use modules.)

> But if we can't land this before the branching of 18, I'll strongly suggest to not ship the std.compat module since this patch is essential to the usability of std.compat module.

I'm not sure that's a good idea. However I expect to finish the code part next week. Due to holidays it might take a bit longer than usual to land.


https://github.com/llvm/llvm-project/pull/74945