[libcxx-commits] [libcxx] [libc++] Protect the libc++ implementation from CUDA SDK's `__noinline__` macro (PR #73838)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 19 15:37:54 PST 2023


https://github.com/philnik777 requested changes to this pull request.

@EricWF Please don't just overrule people. I don't see why we should make this comparatively complex change if we can just slightly change how we write the attribute. I don't see any reason fur us to make our implementation work super well with cude if there doesn't seem to be much incentive from nvidia to make things work well for other libraries. I'm also not convinced that this parallels with other macros we push and pop, since this isn't about conformance. This is only about a not necessarily super large optimization.

https://github.com/llvm/llvm-project/pull/73838


More information about the libcxx-commits mailing list