[libcxx-commits] [libcxx] [ASan][libc++] Annotating `std::basic_string` with all allocators (PR #75845)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 19 12:24:14 PST 2023


https://github.com/EricWF requested changes to this pull request.

I'm pretty opposed to a couple of aspects of this patch.

1. I think the customization point `std::__asan_annotate_container_with_allocator` encourages users to (A) use internals, (B) specialize STL types, and (C) configure the customization point for types they don't own.

2. The added tests contain a bunch of UB. 


Could you please provide an example that is well-formed? Then we can figure out a more appropriate way to provide the customization needed.

https://github.com/llvm/llvm-project/pull/75845


More information about the libcxx-commits mailing list