[libcxx-commits] [libcxx] de5c49f - [libc++] Restore order of includes on Windows to unbreak the build

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 18 14:44:22 PST 2023


Author: Louis Dionne
Date: 2023-12-18T17:42:47-05:00
New Revision: de5c49f7e63f3237afe1e647d359cb8a5227ba4d

URL: https://github.com/llvm/llvm-project/commit/de5c49f7e63f3237afe1e647d359cb8a5227ba4d
DIFF: https://github.com/llvm/llvm-project/commit/de5c49f7e63f3237afe1e647d359cb8a5227ba4d.diff

LOG: [libc++] Restore order of includes on Windows to unbreak the build

As reported in [1], it looks like the Windows headers are picky about
the order in which they are included, and the clang-format change broke
the build by reordering the headers.

[1]: https://github.com/llvm/llvm-project/pull/74334#issuecomment-1861719927

Added: 
    

Modified: 
    libcxx/src/support/win32/thread_win32.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/src/support/win32/thread_win32.cpp b/libcxx/src/support/win32/thread_win32.cpp
index a651a3c867873d..8736a532073b4b 100644
--- a/libcxx/src/support/win32/thread_win32.cpp
+++ b/libcxx/src/support/win32/thread_win32.cpp
@@ -11,9 +11,9 @@
 
 #define NOMINMAX
 #define WIN32_LEAN_AND_MEAN
-#include <fibersapi.h>
-#include <process.h>
 #include <windows.h>
+#include <process.h>
+#include <fibersapi.h>
 
 _LIBCPP_BEGIN_NAMESPACE_STD
 


        


More information about the libcxx-commits mailing list