[libcxx-commits] [libcxx] [libc++] Fixes time formatter test output for Linux on PowerPC (PR #75526)

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Sat Dec 16 05:16:40 PST 2023


================
@@ -821,7 +821,9 @@ static void test_valid_values_date_time() {
   // Use the global locale (fr_FR)
   check(
 // https://sourceware.org/bugzilla/show_bug.cgi?id=24054
-#if defined(__GLIBC__) && __GLIBC__ <= 2 && __GLIBC_MINOR__ < 29
+#if defined(__powerpc__) && defined(__linux__)
+      SV("%c='jeu. 01 janv. 1970 00:00:00 UTC'\t%Ec='jeu. 01 janv. 1970 00:00:00 UTC'\n"),
----------------
mordante wrote:

I think that is quite hard. The C++ code uses libc's locale. Unfortunately different vendors have different view how things are done in a specific locale. I agree this is not great, but most of our locale specific tests have a lot of `#ifdef`s.

https://github.com/llvm/llvm-project/pull/75526


More information about the libcxx-commits mailing list