[libcxx-commits] [libcxx] [libc++][NFC] Simplify features for detecting atomics' support. (PR #75553)

via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 14 20:35:55 PST 2023


================
@@ -183,25 +183,26 @@ def _getAndroidDeviceApi(cfg):
         actions=[AddLinkFlag("-latomic")],
     ),
     Feature(
-        name="non-lockfree-atomics",
+        name="has-64-bit-atomics",
----------------
EricWF wrote:

I think this name is both an improvement (because it calls out the size being the factor here), but also gets worse because locking atomics are still atomic. I wouldn't understand the meaning of this feature check if I were just reading it in the test.

https://github.com/llvm/llvm-project/pull/75553


More information about the libcxx-commits mailing list