[libcxx-commits] [lld] [clang] [libcxx] [llvm] [libc] [mlir] [libcxxabi] [openmp] [lldb] [clang-tools-extra] [compiler-rt] [flang] [llvm] Support IFuncs on Darwin platforms (PR #73686)

Ahmed Bougacha via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 14 11:11:55 PST 2023


================
@@ -2169,8 +2169,11 @@ void AsmPrinter::emitGlobalIFunc(Module &M, const GlobalIFunc &GI) {
     MCSymbol *LocalAlias = getSymbolPreferLocal(GI);
     if (LocalAlias != Name)
       OutStreamer->emitAssignment(LocalAlias, Expr);
-  } else if (TM.getTargetTriple().isOSBinFormatMachO() &&
-             getIFuncMCSubtargetInfo()) {
+
+    return;
+  }
+
+  if (TM.getTargetTriple().isOSBinFormatMachO() && getIFuncMCSubtargetInfo()) {
----------------
ahmedbougacha wrote:

oh I meant literally:
```
  if (!TM.getTargetTriple().isOSBinFormatMachO() || !getIFuncMCSubtargetInfo())
      llvm::report_fatal_error("IFuncs are not supported on this platform");
```

https://github.com/llvm/llvm-project/pull/73686


More information about the libcxx-commits mailing list