[libcxx-commits] [libcxx] [libcxxabi] [libc++] tests with picolibc: enable exceptions (PR #75462)

[David Spickett via libcxx-commits]

Dominik =?utf-8?q?Wójt?= <dominik.wojt at arm.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/75462 at github.com>


================
@@ -13,17 +13,18 @@ set(COMPILER_RT_BUILD_XRAY OFF CACHE BOOL "")
 set(COMPILER_RT_DEFAULT_TARGET_ONLY ON CACHE BOOL "")
 set(LIBCXXABI_BAREMETAL ON CACHE BOOL "")
 set(LIBCXXABI_ENABLE_ASSERTIONS OFF CACHE BOOL "")
-set(LIBCXXABI_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
+set(LIBCXXABI_ENABLE_EXCEPTIONS ON CACHE BOOL "")
 set(LIBCXXABI_ENABLE_SHARED OFF CACHE BOOL "")
 set(LIBCXXABI_ENABLE_STATIC ON CACHE BOOL "")
+set(LIBCXXABI_ENABLE_STATIC_UNWINDER ON CACHE BOOL "")
 set(LIBCXXABI_ENABLE_THREADS OFF CACHE BOOL "")
 set(LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "")
 set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
-set(LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
+set(LIBCXX_ENABLE_EXCEPTIONS ON CACHE BOOL "")
 set(LIBCXX_ENABLE_FILESYSTEM OFF CACHE STRING "")
 set(LIBCXX_ENABLE_MONOTONIC_CLOCK OFF CACHE BOOL "")
 set(LIBCXX_ENABLE_RANDOM_DEVICE OFF CACHE BOOL "")
-set(LIBCXX_ENABLE_RTTI OFF CACHE BOOL "")
+set(LIBCXX_ENABLE_RTTI ON CACHE BOOL "")
----------------
DavidSpickett wrote:

Only 4 things change here, so I'd maybe do this as aarch64 has done. Then again, we have caches for armv7 and 8 that just enable exceptions and thumb mode. I think it was probably more acceptable then just because the caches are a lot smaller than armv7m's.

(in a way, aarch64 is actually the odd one out)

There's some value to having a full cache file for purposes other than the buildbot (as examples), so not sure. Don't change it now but if one of the other reviewers feels like it should be only one cache file, I wouldn't object to it.

https://github.com/llvm/llvm-project/pull/75462