[libcxx-commits] [libcxx] ae85b39 - [libc++] tests with picolibc: mark fenv tests as unsupported (#74610)
via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Dec 12 06:48:53 PST 2023
Author: Dominik Wójt
Date: 2023-12-12T09:48:50-05:00
New Revision: ae85b39396a69afa5c58f06c2f9a4a0d94e94ef6
URL: https://github.com/llvm/llvm-project/commit/ae85b39396a69afa5c58f06c2f9a4a0d94e94ef6
DIFF: https://github.com/llvm/llvm-project/commit/ae85b39396a69afa5c58f06c2f9a4a0d94e94ef6.diff
LOG: [libc++] tests with picolibc: mark fenv tests as unsupported (#74610)
The FE_* macros checked for in cfenv.pass.cpp are not required to be
defined, if the relevant options are _not_ available. Picolibc happens
not to provide these on some platforms.
Added:
Modified:
libcxx/test/std/depr/depr.c.headers/fenv_h.compile.pass.cpp
libcxx/test/std/numerics/cfenv/cfenv.syn/cfenv.pass.cpp
Removed:
################################################################################
diff --git a/libcxx/test/std/depr/depr.c.headers/fenv_h.compile.pass.cpp b/libcxx/test/std/depr/depr.c.headers/fenv_h.compile.pass.cpp
index dcc97573d60733..289a3d1e5c63d1 100644
--- a/libcxx/test/std/depr/depr.c.headers/fenv_h.compile.pass.cpp
+++ b/libcxx/test/std/depr/depr.c.headers/fenv_h.compile.pass.cpp
@@ -6,8 +6,9 @@
//
//===----------------------------------------------------------------------===//
-// Floating point exceptions are required for the FE_... macros to be defined.
-// XFAIL: LIBCXX-PICOLIBC-FIXME
+// Picolibc does not define some of the floating point environment macros for
+// arm platforms without hardware floating point support.
+// UNSUPPORTED: LIBCXX-PICOLIBC-FIXME
// <fenv.h>
diff --git a/libcxx/test/std/numerics/cfenv/cfenv.syn/cfenv.pass.cpp b/libcxx/test/std/numerics/cfenv/cfenv.syn/cfenv.pass.cpp
index 7b3b490eba273a..e6244c745549cd 100644
--- a/libcxx/test/std/numerics/cfenv/cfenv.syn/cfenv.pass.cpp
+++ b/libcxx/test/std/numerics/cfenv/cfenv.syn/cfenv.pass.cpp
@@ -6,8 +6,9 @@
//
//===----------------------------------------------------------------------===//
-// Floating point exceptions are required for the FE_... macros to be defined.
-// XFAIL: LIBCXX-PICOLIBC-FIXME
+// Picolibc does not define some of the floating point environment macros for
+// arm platforms without hardware floating point support.
+// UNSUPPORTED: LIBCXX-PICOLIBC-FIXME
// <cfenv>
More information about the libcxx-commits
mailing list