[libcxx-commits] [libcxx] [libc++] tests with picolibc: add has-complete-fenv feature (PR #74610)

Dominik Wójt via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 12 02:57:27 PST 2023


================
@@ -212,6 +212,35 @@ def _getAndroidDeviceApi(cfg):
           """,
         ),
     ),
+    # Some platform do not provide complete floating point environment.
+    Feature(
+        name="has-compolete-fenv",
+        when=lambda cfg: sourceBuilds(
+            cfg,
+            """
+            #include <fenv.h>
+
+            #if !( \
+                defined FE_DIVBYZERO \
----------------
domin144 wrote:

It used to make sense to me, as I am doing tests on more configurations of picolibc and some of them do provide all the necessary macros (e.g. armv7m with fpu). Now, I realize this is not that useful for libc++ itself, as only one configuration is tested in CI here.

Yet, still I will switch from XFAIL to UNSUPPORTED to cater the configurations, where this test would pass.

https://github.com/llvm/llvm-project/pull/74610


More information about the libcxx-commits mailing list