[libcxx-commits] [libcxx] [libc++][test] Enhance `ADDITIONAL_COMPILE_FLAGS` to work with MSVC (PR #74974)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 11 12:51:33 PST 2023


================
@@ -13,9 +13,12 @@
 import subprocess
 import sys
 
-_isClang = lambda cfg: "__clang__" in compilerMacros(cfg) and "__apple_build_version__" not in compilerMacros(cfg)
+_isAnyClang = lambda cfg: "__clang__" in compilerMacros(cfg)
----------------
ldionne wrote:

I would much prefer if we had a way of detecting `cl-style-warnings` here. I am waging a war against stale features in our test suite, and `cl-style-warnings` without any way to detect it looks exactly like a stale Lit feature.

https://github.com/llvm/llvm-project/pull/74974


More information about the libcxx-commits mailing list