[libcxx-commits] [libcxx] [libcxxabi] [ASan][libc++] std::basic_string annotations (PR #72677)

[via libcxx-commits]

AdvenamTacet wrote:

Ok, I made (hopefully) the final iteration, where I  [removed all unnecessary `_LIBCPP_STRING_INTERNAL_MEMORY_ACCESS`](https://github.com/llvm/llvm-project/pull/72677/commits/96f1712418457f21268db22f3b6feaed4b810abc).

This PR does [not turn on short string annotations](https://github.com/llvm/llvm-project/pull/72677/files#diff-534bc2907ddb3b074ded1353d18fd7d578daf1707943b3039bab4ed975aba3b3R662).
I'm not aware of any issues with that implementation.

I tested everything locally with SSO annotations turned on, to have working implementation, in which we can just switch off to on, without any other code modification.

However, right now turning on SSO annotations is not possible due to a [very specific implementation of sstream](https://github.com/llvm/llvm-project/blob/main/libcxx/include/sstream#L412), where `__move_assign` is used. That affects only short string annotations and should not block this PR. I'm going to address this in a separate PR.

@EricWF thank you for the code review and feedback on Discord!

@ldionne if possible, could we please merge it before formatting lands? If you want me to change something, I'm happy to sit to it asap.

https://github.com/llvm/llvm-project/pull/72677