[libcxx-commits] [libcxx] [ASan][libc++] std::basic_string annotations (PR #72677)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 4 13:33:43 PST 2023


https://github.com/EricWF requested changes to this pull request.

Could you please write specific tests for your change. 

I don't think tacking on an assertion to every existing test is the right way to go. I understand the appeal, but I think specific tests written expressly to test this change is the right way to go.

In the past, we've allowed tests to be added like this, but it's resulted in tests that run too long and tests which don't test a single thing.



https://github.com/llvm/llvm-project/pull/72677


More information about the libcxx-commits mailing list