[libcxx-commits] [libcxx] [libc++][test] Make filesystem tests more portable to Windows (PR #74182)

[Stephan T. Lavavej via libcxx-commits]

StephanTLavavej wrote:

Thanks, I hadn't considered the approach of defining macros throughout the entire test suite. We have a force-included header where we could do that:

https://github.com/llvm/llvm-project/blob/21a9c7e6e7b89b2000e2249a5305cf5d0b04ccd2/libcxx/test/support/msvc_stdlib_force_include.h#L12-L17

It would slightly reduce test coverage for our product code, because it would allow the product code to call `min()`/`max()` without extra parens, or call the POSIX names. However, our other test suites would still provide sufficient coverage. This would be much less invasive for libc++'s test suite, so I'll try it - if I can get it to work, I'll close this PR and open a fresh one.




https://github.com/llvm/llvm-project/pull/74182