[libcxx-commits] [libcxx] [libcxxabi] [libc++] Remove dependence on <ciso646> (PR #73271)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Dec 1 07:03:15 PST 2023


================
@@ -12,15 +12,15 @@
 
 // Attempt to get STL specific macros like _LIBCPP_VERSION using the most
 // minimal header possible. If we're testing libc++, we should use `<__config>`.
-// If <__config> isn't available, fall back to <ciso646>.
+// If <__config> isn't available, fall back to <version>.
 #ifdef __has_include
 # if __has_include("<__config>")
 #   include <__config>
 #   define TEST_IMP_INCLUDED_HEADER
 # endif
 #endif
 #ifndef TEST_IMP_INCLUDED_HEADER
-#include <ciso646>
+#  include <version>
----------------
ldionne wrote:

`<__config>` is only a libc++ thing, and we make no attempt to support another hypothetical library that would define that header. It is diligent from you to consider that case, but yeah that's not really a concern here.

https://github.com/llvm/llvm-project/pull/73271


More information about the libcxx-commits mailing list