[libcxx-commits] [libcxx] f19571e - [libc++] Revert "Compile MSAN/TSAN failing test with -O1 (#73555)"

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Dec 1 06:02:55 PST 2023


Author: Louis Dionne
Date: 2023-12-01T09:02:16-05:00
New Revision: f19571ee781de932390e8983267263f504e99e1f

URL: https://github.com/llvm/llvm-project/commit/f19571ee781de932390e8983267263f504e99e1f
DIFF: https://github.com/llvm/llvm-project/commit/f19571ee781de932390e8983267263f504e99e1f.diff

LOG: [libc++] Revert "Compile MSAN/TSAN failing test with -O1 (#73555)"

This reverts commit 61aef978d6ab1553c48bbd9bf807a277b22451c1, which
broke the CI on GCC.

Added: 
    

Modified: 
    libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
    libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp b/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
index 4a694e0dd71c861..946c2cfabf02b63 100644
--- a/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
+++ b/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
@@ -9,10 +9,6 @@
 // REQUIRES: long_tests
 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
 
-// This test chokes on the sanitizers during CI runs. It appears we can address most of this by simply enabling optimizations.
-// ADDITIONAL_COMPILE_FLAGS(msan): -O1
-// ADDITIONAL_COMPILE_FLAGS(tsan): -O1
-
 // <deque>
 
 // template <class InputIterator>

diff  --git a/libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp b/libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp
index 9ab8b6f42749242..d98a73d296668bb 100644
--- a/libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp
+++ b/libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp
@@ -8,10 +8,6 @@
 //
 // REQUIRES: long_tests
 
-// This test is super slow, in particular with msan or tsan. In order to avoid timeouts and to
-// spend less time waiting for this particular test to complete we compile with optimizations.
-// ADDITIONAL_COMPILE_FLAGS: -O1
-
 // <random>
 
 // template<class IntType = int>


        


More information about the libcxx-commits mailing list