[libcxx-commits] [PATCH] D159171: [libc++][hardening] Remove hardening from release notes, undeprecate safe mode

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added inline comments.


================
Comment at: libcxx/test/libcxx/assertions/assertions_disabled.pass.cpp:12
+// _LIBCPP_ENABLE_ASSERTIONS=1 under some configurations.
+
+// ADDITIONAL_COMPILE_FLAGS: -Wno-macro-redefined -D_LIBCPP_ENABLE_ASSERTIONS=0
----------------
ldionne wrote:
> ldionne wrote:
> > You'll need an `XFAIL: hardening-mode={{hardened|debug}}` here.
> Actually this needs to be `XFAIL: libcpp-has-hardened-mode || libcpp-has-debug-mode` because `libcpp-hardening-mode=FOO` doesn't exist yet on `release/17.x`.
> 
> While you're at it, can you grep your patch for `libcpp-hardening-mode`? Any reference to it is basically a mistake.
Thanks! Fixed and manually tested now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159171/new/

https://reviews.llvm.org/D159171