[libcxx-commits] [PATCH] D93971: Add freestanding parameter to libcxx lit

Thu Aug 31 12:42:24 PDT 2023

ldionne commandeered this revision.
ldionne edited reviewers, added: bcraig; removed: ldionne.
ldionne added a comment.
Herald added a project: All.

In D93971#2562439 <https://reviews.llvm.org/D93971#2562439>, @bcraig wrote:

> I think both paths 1 and 2 make sense long term.  They start "actually" testing the new freestanding parameter as soon as we start sprinkling `UNSUPPORTED:libcpp-any-freestanding` all over the place, but it will likely be months before we get a passing CI run.
>
> Any thoughts on what you would like to see?  Is it ok to have a broken CI bot for a while?  Or do I need to fix the tests as part of this change as well?

I think this is the approach we should take. We should prepare this patch (the test suite would fail). Then, we can make iterative fixes to libc++ as separate patches until this patch finally passes.

We are moving to GitHub PRs so I'll need to close this, but I would suggest re-opening this as a PR if you still have interest in pursuing this. It would be really nice to make libc++ officially conform to Freestanding.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93971/new/

https://reviews.llvm.org/D93971