[libcxx-commits] [PATCH] D159171: [libc++][hardening] Remove hardening from release notes, undeprecate safe mode

Thu Aug 31 10:29:53 PDT 2023

ldionne added a comment.

In D159171#4631578 <https://reviews.llvm.org/D159171#4631578>, @Mordante wrote:

> The patch is quite large, I assume most of it's just reverts and only little new code. Is that right?

The biggest part of the patch is the changes to the test suite. Those are making sure that we test the safe mode again like we used to. I went over these changes and they look OK to me, but CI will help validate that.

================
Comment at: libcxx/test/libcxx/assertions/assertions_disabled.pass.cpp:12
+// _LIBCPP_ENABLE_ASSERTIONS=1 under some configurations.
+
+// ADDITIONAL_COMPILE_FLAGS: -Wno-macro-redefined -D_LIBCPP_ENABLE_ASSERTIONS=0
----------------
ldionne wrote:
> You'll need an `XFAIL: hardening-mode={{hardened|debug}}` here.
Actually this needs to be `XFAIL: libcpp-has-hardened-mode || libcpp-has-debug-mode` because `libcpp-hardening-mode=FOO` doesn't exist yet on `release/17.x`.

While you're at it, can you grep your patch for `libcpp-hardening-mode`? Any reference to it is basically a mistake.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159171/new/

https://reviews.llvm.org/D159171