[libcxx-commits] [PATCH] D127587: [libc++] Use explicit module cache path in tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne commandeered this revision.
ldionne edited reviewers, added: abrachet; removed: ldionne.
ldionne added a comment.

[Github PR transition cleanup]

I think this is reasonable enough that we don't need to look into changing anything. I think it would be better to define a substitution like `%{modules-cache}` which is global to the test suite and then use `-fmodules-cache-path=%{modules-cache}` here in this test and also in `params.py` (where we currently define a modules cache path for clang-modules builds).

@abrachet If you want to investigate this, please open that review as a GH PR and we'll have a look. But otherwise the current state is acceptable as well.

I will commandeer this to close it to clear the review queue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127587/new/

https://reviews.llvm.org/D127587