[libcxx-commits] [PATCH] D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler

Xing Xue via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 31 08:03:39 PDT 2023


xingxue marked 3 inline comments as done.
xingxue added inline comments.


================
Comment at: libunwind/test/aix_signal_unwind.pass.sh.S:159
+        std 0, 16(1)
+        ld 3, L..C0(2)                  # @badp
+        ld 4, 0(3)
----------------
stephenpeckham wrote:
> I suggest you add "bl $+4" to modify LR as if an internal function had been called.
Added the instruction as suggested, thanks!


================
Comment at: libunwind/test/aix_signal_unwind.pass.sh.S:208
+        stw 0, 8(1)
+        lwz 3, L..C0(2)                 # @badp
+        lwz 4, 0(3)
----------------
stephenpeckham wrote:
> add "bl $+4"
Added the instruction as suggested, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158655/new/

https://reviews.llvm.org/D158655



More information about the libcxx-commits mailing list