[libcxx-commits] [PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay added inline comments.


================
Comment at: clang/include/clang/Basic/SizedDeallocation.h:23
+namespace clang {
+inline llvm::VersionTuple sizedDeallocMinVersion(llvm::Triple::OSType OS) {
+  switch (OS) {
----------------
wangpc wrote:
> MaskRay wrote:
> > Does this need to be in Basic/? It's only used by clang/lib/Driver/ToolChains/Darwin.cpp
> > 
> > 
> This file is just copied and changed from `clang/include/clang/Basic/AlignedAllocation.h` actually, I don't know which directory is more suitable.
If this is only used by clangDriver, I am not sure we want to expose it as a public header under include/.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112921/new/

https://reviews.llvm.org/D112921