[libcxx-commits] [PATCH] D156954: [lit] Improve test output from lit's internal shell

[Joel E. Denny via Phabricator via libcxx-commits]

jdenny added a comment.

In D156954#4626071 <https://reviews.llvm.org/D156954#4626071>, @dyung wrote:

> Getting close, the last failure just seems to be due to the path separators '/' vs. '\' being explicitly checked for.

Yes.  By now, I really ought to remember that one when writing tests.

OK, I landed these additional commits to fix various issues (shell quoting and `/` vs `\`) in lit tests running in windows:

- f254bbf23374190c88a2b1a5f163622fbec9a936 <https://reviews.llvm.org/rGf254bbf23374190c88a2b1a5f163622fbec9a936>
- 3db5db92d746bad8ba1762ca290a176e25d48565 <https://reviews.llvm.org/rG3db5db92d746bad8ba1762ca290a176e25d48565>
- 012d844fb856a89368aca95ca994726554b90f22 <https://reviews.llvm.org/rG012d844fb856a89368aca95ca994726554b90f22>
- b6bd9d275f783f8150c8a04145ef2a31edb4fddf <https://reviews.llvm.org/rGb6bd9d275f783f8150c8a04145ef2a31edb4fddf>

Those commits fix lit's tests but do not change lit itself.  See the commit logs there for details.

Sorry it took me a while.

In D156954#4625928 <https://reviews.llvm.org/D156954#4625928>, @dyung wrote:

> @jdenny I am the owner of the llvm-clang-x86_64-sie-win bot, let me know if you need any help to fix the failures from your change.

One thing all bot maintainers might consider doing is adding the following to the environment:

  export FILECHECK_OPTS='-dump-input-filter=all -vv -color'

As discussed in f254bbf23374190c88a2b1a5f163622fbec9a936 <https://reviews.llvm.org/rGf254bbf23374190c88a2b1a5f163622fbec9a936>, this provides a lot more info for debugging test fails.  For the sake of users running tests locally who want less verbose output, it's not the FileCheck default.  However, it's easy for them to run again with the above when needed.  It's not easy to do that for CI on a system you don't own.

(Of course, you might drop `-color` if color doesn't render well.)

Just a suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156954/new/

https://reviews.llvm.org/D156954