[libcxx-commits] [PATCH] D158970: [libc++][hardening] Mark a few stray assertions as uncategorized.
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Aug 29 03:41:15 PDT 2023
Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.
LGTM modulo one nit.
================
Comment at: libcxx/include/__algorithm/three_way_comp_ref_type.h:53
__expected = _Order::less;
- _LIBCPP_ASSERT(__comp_(__l, __r) == __expected, "Comparator does not induce a strict weak ordering");
+ _LIBCPP_ASSERT_UNCATEGORIZED(__comp_(__l, __r) == __expected, "Comparator does not induce a strict weak ordering");
(void)__l;
----------------
I would suggest to update the title to "Mark the remaining stray assertions as uncategorized."
That makes the scope of the changes clear.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158970/new/
https://reviews.llvm.org/D158970
More information about the libcxx-commits
mailing list