[libcxx-commits] [PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

[Wang Pengcheng via Phabricator via libcxx-commits]

wangpc marked 2 inline comments as done.
wangpc added inline comments.


================
Comment at: clang/include/clang/Basic/SizedDeallocation.h:23
+namespace clang {
+inline llvm::VersionTuple sizedDeallocMinVersion(llvm::Triple::OSType OS) {
+  switch (OS) {
----------------
MaskRay wrote:
> Does this need to be in Basic/? It's only used by clang/lib/Driver/ToolChains/Darwin.cpp
> 
> 
This file is just copied and changed from `clang/include/clang/Basic/AlignedAllocation.h` actually, I don't know which directory is more suitable.


================
Comment at: clang/include/clang/Basic/SizedDeallocation.h:36
+  case llvm::Triple::ZOS:
+    return llvm::VersionTuple(); // All z/OS versions have no support.
+  }
----------------
MaskRay wrote:
> This is major=minor=0, which is probably not desired.
> 
> We can just omit ZOS.
We have ZOS in `alignedAllocMinVersion` in `clang/include/clang/Basic/AlignedAllocation.h` too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112921/new/

https://reviews.llvm.org/D112921