[libcxx-commits] [PATCH] D158918: [libc++abi][WebAssembly] Support Wasm EH

[Derek Schuff via Phabricator via libcxx-commits]

dschuff added a comment.

Thanks for posting this.
I don't really have any new comments about the code itself (I guess that's not surprising since I reviewed it before ...)
I notice there are no changes to the build system for this; presumably that's just because we don't have CMake support for building LLVM libraries for wasm in general. I wonder whether LLVM or the libc++abi maintainers have any policies about that.
Also, regarding the `__USING_WASM_EXCEPTIONS__` macro: this is not predefined by the compiler but needs to be defined by the builder/build system, right? I wonder if that's something that belongs in <__cxxabi_config.h>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158918/new/

https://reviews.llvm.org/D158918