[libcxx-commits] [PATCH] D153658: [libc++] Make everything in namespace std have default type visibility and hidden visibility and remove _LIBCPP_ENUM_VIS

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 28 13:52:26 PDT 2023


EricWF added a comment.

I have to apologize for my previous comment.

When I was initially testing this change, I made some unknown mistake which make it appear as though there had been a 3x symbol increase in a test shared library.
However, when I went to reproduce, I couldn't replicate the result and indeed there was almost no movement in the amount of symbols.

I'm sorry. I spoke too soon and too strongly. I will work to improve my communication .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153658/new/

https://reviews.llvm.org/D153658



More information about the libcxx-commits mailing list