[libcxx-commits] [PATCH] D158861: [llvm] Move CallInst::CreateMalloc to IRBuilderBase::CreateMalloc

[Konrad Wilhelm Kleine via Phabricator via libcxx-commits]

kwk updated this revision to Diff 553961.
kwk added a comment.

Address review comments.

- Undo changes to libcxxabi/test/test_demangle.pass.cpp
- Undo changes to llvm/bindings/ocaml/llvm/llvm.mli
- Change comment from CallInst:: to IRBuilderBase::
- Drop insertion because IRBuilderBase::CreateMalloc already does it
- Don't require a name in IRBuilderBase::CreateMalloc method, as usual
- Directly return value from CreateMalloc and wrap it as an LLVMValueRef
- Drop left over bitcast comment
- Use Context member
- Pass Name instead of "MCall"
- Use IRBuilderBase::CreateCall instead of CallInst::Create
- Call IRBuilder's CreateBinOp() to actually insert the instruction


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158861/new/

https://reviews.llvm.org/D158861

Files:
  llvm/bindings/ocaml/llvm/llvm.mli
  llvm/examples/BrainF/BrainF.cpp
  llvm/include/llvm/IR/IRBuilder.h
  llvm/include/llvm/IR/Instructions.h
  llvm/lib/IR/Core.cpp
  llvm/lib/IR/IRBuilder.cpp
  llvm/lib/IR/Instructions.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp
  polly/lib/CodeGen/IslNodeBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158861.553961.patch
Type: text/x-patch
Size: 18153 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230828/fe61f555/attachment-0001.bin>