[libcxx-commits] [PATCH] D157625: [libc++][modules] Simplifies C++20 module testing.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Aug 26 03:50:43 PDT 2023


Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/utils/libcxx/test/params.py:127
         actions=lambda enable_modules: [
             AddFeature("modules-build"),
             AddCompileFlag("-fmodules"),
----------------
ldionne wrote:
> In a separate patch, we should probably change this to `clang-modules-build` or `modules-build=clang` (and then we could have `modules-build=std`).
See D158927


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157625/new/

https://reviews.llvm.org/D157625



More information about the libcxx-commits mailing list