[libcxx-commits] [PATCH] D158749: [libc++] Implement LWG3464(istream::gcount() can overflow)

[Yurong via Phabricator via libcxx-commits]

yronglin marked 3 inline comments as done.
yronglin added a comment.

Many thanks for your review! @Mordante



================
Comment at: libcxx/include/istream:219
+private:
+    inline _LIBCPP_INLINE_VISIBILITY
+    void __inc_gcount() {
----------------
Mordante wrote:
> Please use my suggestion, that matches our latest coding standard.
> 
> Nit: I prefer to have private, protected, public in that order, especially since there is already a private section.
Sorry, somehow I have missed this comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158749/new/

https://reviews.llvm.org/D158749