[libcxx-commits] [PATCH] D158749: [WIP][libc++] Implement LWG3464(istream::gcount() can overflow)

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/istream:219
+private:
+    inline _LIBCPP_INLINE_VISIBILITY
+    void __inc_gcount() {
----------------
Please use my suggestion, that matches our latest coding standard.

Nit: I prefer to have private, protected, public in that order, especially since there is already a private section.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158749/new/

https://reviews.llvm.org/D158749