[libcxx-commits] [PATCH] D150831: [libc++] Implement ranges::ends_with

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.nonmodifying/alg.ends_with/ranges.ends_with.pass.cpp:274
+
+  { // benmark test to check that random access optimization
+    std::__1::vector<int> a = {100, 32};
----------------
Instead, we should add a benchmark under `<monorepo>/libcxx/benchmarks` and post the results of that benchmark here in this review. I know this isn't an automated test, but the test as-is risks being flaky. Let's leave the benchmarks in `libcxx/benchmarks` and we can figure out a way to track performance through time (and potentially compare performance of different operations?) more generally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150831/new/

https://reviews.llvm.org/D150831