[libcxx-commits] [PATCH] D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler

Xing Xue via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 25 13:30:57 PDT 2023


xingxue marked an inline comment as done.
xingxue added inline comments.


================
Comment at: libunwind/src/UnwindCursor.hpp:2538
 
   if (nextReturnAddress > 0x01 && nextReturnAddress < 0x10000) {
     _LIBUNWIND_TRACE_UNWINDING("The next is a signal handler frame: "
----------------
stephenpeckham wrote:
> This code wasn't changed, but the check could be done at the beginning of the function instead of the end. With this change, isSignalFrame does not need to be updated.
`isSignalFrame` needs to be undated for libunwind call `unw_is_signal_frame()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158655/new/

https://reviews.llvm.org/D158655



More information about the libcxx-commits mailing list