[libcxx-commits] [PATCH] D158749: [WIP][libc++] Implement LWG3464(istream::gcount() can overflow)

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D158749#4614243 <https://reviews.llvm.org/D158749#4614243>, @yronglin wrote:

> I'm so sorry that I have no idea how to test stream size overflow in this change now.

I also see no good way to test this.



================
Comment at: libcxx/include/istream:215
 
+    inline _LIBCPP_HIDE_FROM_ABI_AFTER_V1
+    void __inc_gcount() {
----------------
This is a new function, so no need to change the behaviour after V1.


================
Comment at: libcxx/include/istream:215
 
+    inline _LIBCPP_HIDE_FROM_ABI_AFTER_V1
+    void __inc_gcount() {
----------------
Mordante wrote:
> This is a new function, so no need to change the behaviour after V1.
Why is this function protected and not private?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158749/new/

https://reviews.llvm.org/D158749