[libcxx-commits] [PATCH] D158450: [libcxx] Provide set_new_handler/get_new_handler on Windows

Thu Aug 24 05:08:46 PDT 2023

mstorsjo added inline comments.

================
Comment at: libcxx/include/new:172
+#else
+#define _NEW_HANDLER_EXPORTED _LIBCPP_EXPORTED_FROM_ABI
+#endif
----------------
Hmm, does this mean that these functions won't be exported in the case of the DLL build? Wouldn't that lead to linking against the msvcprt implementation for `set_new_handler` and failing to link `get_new_handler`?

I see that this did pass in the CI build though - how does that work?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158450/new/

https://reviews.llvm.org/D158450