[libcxx-commits] [PATCH] D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for working on this!
I mainly glossed over the patch and didn't do a real review. Just a few comments.



================
Comment at: libcxx/include/__ranges/concepts.h:151
+      ranges::input_range<_Rp> && std::move_constructible<ranges::range_reference_t<_Rp>> &&
+      std::move_constructible<ranges::range_rvalue_reference_t<_Rp>>; // exposition only
+
----------------
This is already implied by the __uglified name. The same at other places.


================
Comment at: libcxx/include/__ranges/enumerate_view.h:64
+  _LIBCPP_HIDE_FROM_ABI constexpr enumerate_view()
+    requires default_initializable<_View>
+  = default;
----------------
Can you test whether this helps `clang-format` to do slightly better?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157193/new/

https://reviews.llvm.org/D157193