[libcxx-commits] [PATCH] D158547: [PowerPC] Exclude frexp(long double) on linux

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 23 08:57:27 PDT 2023


Mordante added inline comments.


================
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-cxx23-clang.pass.cpp:61
   ASSERT_NOT_CONSTEXPR_CXX23(std::frexp(0.0, &DummyInt) == 0.0);
-  ASSERT_NOT_CONSTEXPR_CXX23(std::frexp(0.0L, &DummyInt) == 0.0L);
   ASSERT_NOT_CONSTEXPR_CXX23(std::frexpf(0.0f, &DummyInt) == 0.0f);
----------------
I prefer an `#if ! defined(__LONG_DOUBLE_IBM128__)` here instead of moving this line. That keeps the order as expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158547/new/

https://reviews.llvm.org/D158547



More information about the libcxx-commits mailing list