[libcxx-commits] [PATCH] D156052: [libc++][doc] Improves contribution page.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Thanks for working on this!



================
Comment at: libcxx/docs/Contributing.rst:49
+``__ugly_names`` we avoid that problem. Other standard libraries and
+compilers use these names too. To avoid common clashes, the test in
+``libcxx/test/libcxx/system_reserved_names.gen.py``
----------------



================
Comment at: libcxx/docs/Contributing.rst:78-79
+  ``_LIBCPP_HIDE_FROM_ABI`` instead.
+- Prefer ``using foo = int`` over ``typedef int foo``. In libc++ this is
+  supported in all versions of C++.
+
----------------



================
Comment at: libcxx/docs/Contributing.rst:87-89
+- Keep patches small and self-contained. Large patches are harder to review and
+  take a significant amount of time. It's fine to have multiple patches to
+  implement one feature.
----------------



================
Comment at: libcxx/docs/Contributing.rst:102
+  functions ``constexpr`` in C++20 is done by using ``_LIBCPP_CONSTEXPR_SINCE_CXX20``. This means the function is
+  ``constexpr`` in C++20 and later. The Standard does not allow to make
+  this available in C++17 or earlier, so we use a macro to implement this
----------------



================
Comment at: libcxx/docs/Contributing.rst:107-110
+- The ``#libcxx`` channel on
+  `LLVM's Discord server <https://discord.gg/jzUbyP26tQ>`_.
+  This is the place where most discussion regarding libc++ happens and
+  the active contributors are available for questions.
----------------
We already have a reference to the Discord channel above, so I'd drop this bullet point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156052/new/

https://reviews.llvm.org/D156052