[libcxx-commits] [PATCH] D156019: [libc++] Adds __throw_system_error overload.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 22 10:39:57 PDT 2023


ldionne added inline comments.


================
Comment at: libcxx/src/system_error.cpp:279
     : runtime_error(__init(error_code(ev, ecat), "")),
       __ec_(error_code(ev, ecat))
 {
----------------
I think we should try to avoid adding this to the dylib, since otherwise we need to introduce a new availability macro just for this function. I would just define it in the headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156019/new/

https://reviews.llvm.org/D156019



More information about the libcxx-commits mailing list