[libcxx-commits] [PATCH] D158192: [libc++][modules] Generates std.cppm.in.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/modules/std.cppm.in:1
 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
----------------
Commit typo: `instead of manually duplication` => `instead of manually duplicating`


================
Comment at: libcxx/utils/libcxx/header_information.py:147-150
+# These headers are required by the latest (draft) Standard but have not been
+# implemented yet. They are used in the generated module input. When the header
+# is added and this list is not updated the C++23 standard modules will fail to
+# build.
----------------



================
Comment at: libcxx/utils/libcxx/header_information.py:189
+
+# The headers used in the std and std.compat modules.
+module_headers = [
----------------



================
Comment at: libcxx/utils/libcxx/header_information.py:194
+    if not header.endswith(".h")
+    # These headers have been removed in C++20 so never are part of a module.
+    and not header in ["ccomplex", "ciso646", "cstdbool", "ctgmath"]
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158192/new/

https://reviews.llvm.org/D158192