[libcxx-commits] [PATCH] D157744: [libc++][CI] Moves modules build to C++23.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ comments, thanks!



================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:141
     agents:
       queue: "libcxx-builders"
       os: "linux"
----------------
Commit message typo: `wouls fail `


================
Comment at: libcxx/utils/ci/run-buildbot:55-58
+ENABLE_STD_MODULES  Whether to enable or disable building the C++23 std
+					modules. This variable is optional.
+                    TODO MODULES remove when all supported compilers support
+                    modules.
----------------
Tabs/space conflict?


================
Comment at: libcxx/utils/ci/run-buildbot:144
           -DLIBCXX_ENABLE_CLANG_TIDY=${ENABLE_CLANG_TIDY} \
+		  ${ENABLE_STD_MODULES} \
           -DLLVM_LIT_ARGS="-sv --show-unsupported --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
----------------
Also a tab!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157744/new/

https://reviews.llvm.org/D157744