[libcxx-commits] [PATCH] D158011: Make _LIBUNWIND_SUPPORT_FRAME_APIS not conditional on target architecure.
Fangrui Song via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Aug 21 13:38:58 PDT 2023
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LGTM if LIBUNWIND_ENABLE_FRAME_APIS defaults to OFF
================
Comment at: libunwind/CMakeLists.txt:54
option(LIBUNWIND_INSTALL_HEADERS "Install the libunwind headers." ON)
+option(LIBUNWIND_ENABLE_FRAME_APIS "Include libgcc-compatible frame apis." ON)
+
----------------
LGTM if this is changed to OFF
================
Comment at: libunwind/CMakeLists.txt:55
+option(LIBUNWIND_ENABLE_FRAME_APIS "Include libgcc-compatible frame apis." ON)
+
----------------
delete this blank line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158011/new/
https://reviews.llvm.org/D158011
More information about the libcxx-commits
mailing list