[libcxx-commits] [PATCH] D158357: [libc++][C++20 modules] Tests no unicode build.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added a subscriber: arichardson.
Herald added a project: All.
Mordante published this revision for review.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Depends on D158347 <https://reviews.llvm.org/D158347>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158357

Files:
  libcxx/cmake/caches/Generic-no-unicode.cmake
  libcxx/docs/Modules.rst
  libcxx/modules/CMakeLists.txt.in
  libcxx/modules/std/print.inc
  libcxx/utils/ci/buildkite-pipeline.yml


Index: libcxx/utils/ci/buildkite-pipeline.yml
===================================================================
--- libcxx/utils/ci/buildkite-pipeline.yml
+++ libcxx/utils/ci/buildkite-pipeline.yml
@@ -653,8 +653,11 @@
         - "**/test-results.xml"
         - "**/*.abilist"
       env:
-          CC: "clang-${LLVM_HEAD_VERSION}"
-          CXX: "clang++-${LLVM_HEAD_VERSION}"
+          # Note: Modules require and absolute path for clang-scan-deps
+          # https://github.com/llvm/llvm-project/issues/61006
+          CC: "/usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang"
+          CXX: "/usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang++"
+          CMAKE: "/opt/bin/cmake"
           ENABLE_CLANG_TIDY: "On"
       agents:
         queue: "libcxx-builders"
Index: libcxx/modules/std/print.inc
===================================================================
--- libcxx/modules/std/print.inc
+++ libcxx/modules/std/print.inc
@@ -13,5 +13,7 @@
   using std::println;
 
   using std::vprint_nonunicode;
+#ifndef _LIBCPP_HAS_NO_UNICODE
   using std::vprint_unicode;
+#endif // _LIBCPP_HAS_NO_UNICODE
 } // namespace std
Index: libcxx/modules/CMakeLists.txt.in
===================================================================
--- libcxx/modules/CMakeLists.txt.in
+++ libcxx/modules/CMakeLists.txt.in
@@ -29,9 +29,6 @@
   endif()
 endmacro()
 
-if(NOT @LIBCXX_ENABLE_UNICODE@)
-  message(FATAL_ERROR "Modules without Unicode support is not yet implemented.")
-endif()
 if(NOT @LIBCXX_ENABLE_EXCEPTIONS@ OR NOT @LIBCXXABI_ENABLE_EXCEPTIONS@)
   message(FATAL_ERROR "Modules without exception support is not yet implemented.")
 endif()
Index: libcxx/docs/Modules.rst
===================================================================
--- libcxx/docs/Modules.rst
+++ libcxx/docs/Modules.rst
@@ -47,6 +47,7 @@
    * ``LIBCXX_ENABLE_THREADS``
    * ``LIBCXX_ENABLE_FILESYSTEM``
    * ``LIBCXX_ENABLE_RANDOM_DEVICE``
+   * ``LIBCXX_ENABLE_UNICODE``
 
 Some of the current limitations
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Index: libcxx/cmake/caches/Generic-no-unicode.cmake
===================================================================
--- libcxx/cmake/caches/Generic-no-unicode.cmake
+++ libcxx/cmake/caches/Generic-no-unicode.cmake
@@ -1 +1,2 @@
+set(LIBCXX_ENABLE_STD_MODULES ON CACHE BOOL "") # TODO MODULES Remove when enabled automatically.
 set(LIBCXX_ENABLE_UNICODE OFF CACHE BOOL "")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158357.551808.patch
Type: text/x-patch
Size: 2397 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230820/51622336/attachment-0001.bin>