[libcxx-commits] [PATCH] D155701: [libc++][expected] Implement LWG3836

Yurong via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Aug 19 08:20:22 PDT 2023


yronglin marked an inline comment as done.
yronglin added a comment.

Thanks a lot for your review! @Mordante



================
Comment at: libcxx/include/__expected/expected.h:178-179
+                      _Not<is_convertible<const expected<_Up, _OtherErr>&, _Tp>>,
+                      _Not<is_convertible<const expected<_Up, _OtherErr>&&, _Tp>> >,
+                true_type >,
             _Not<is_constructible<unexpected<_Err>, expected<_Up, _OtherErr>&>>,
----------------
Mordante wrote:
> Some whitespace fixed. This is not done by clang-format since that breaks in C++03.
Thanks, fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155701/new/

https://reviews.llvm.org/D155701



More information about the libcxx-commits mailing list