[libcxx-commits] [PATCH] D156922: [libc++][CI] Upgrades to LLVM 18 as HEAD version.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:302
 
   - label: "Clang 15"
     command: "libcxx/utils/ci/run-buildbot generic-cxx23"
----------------
philnik wrote:
> Is there a reason we keep 15 around? Also, could we make these changes automatic like we do for GCC?
We still officially support clang-15. The main idea is to make sure we still work with clang-15 so we can be sure backported patches work on clang-15. Once LLVM 17 is released this can be removed.

What do you mean with automatically?


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:339
+  - label: "Clang 17"
+    command: "libcxx/utils/ci/run-buildbot generic-cxx23"
+    artifact_paths:
----------------
philnik wrote:
> 
This will fail until we update to CMake 3.27, which is on my todo list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156922/new/

https://reviews.llvm.org/D156922