[libcxx-commits] [PATCH] D154282: [libc++][chrono] Adds tzdb_list implementation.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 21 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/docs/DesignDocs/TimeZone.rst:91
+  system wide.
+- Overriding ``std::chrono::__libcpp_tzdb_directory()``. This allows
+  applications to specify their own database path and implement their own time
----------------
ldionne wrote:
> Point of discussion: do we really want to let users override this? Unless we have clear uses cases for that, I would recommend not exposing this to users at first. We can do something ad-hoc for our testing needs.
> 
> If we decide not to expose this to users, let's make it clear by not saying `"this allows applications to specify their own database path [...]"`.
I'll remove the part of user specific applications.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154282/new/

https://reviews.llvm.org/D154282