[libcxx-commits] [PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

[Paul Scoropan via Phabricator via libcxx-commits]

pscoro added inline comments.


================
Comment at: flang-rt/unittests/FortranEvaluate/testing.h:1
+#ifndef FORTRAN_EVALUATE_TESTING_H_
+#define FORTRAN_EVALUATE_TESTING_H_
----------------
klausler wrote:
> Why was this file (and testing.cpp) added instead of being moved, like other files were?
> 
> Why are the unit tests for the Evaluate library being moved into flang-rt?  The Evaluate library is only used by the compiler for constant folding and expression processing; it is not part of the runtime.
There are 2 unit tests (reshape and ISO-Fortran-Binding) that include runtime headers. Neither of these tests included headers from any other Flang libraries so I chose to move them under flang-rt. I preserved the testsuite name FortranEvaluate because thats where they came from. I am not too confident in this decision. Let me know if there is an alternative you prefer.

These testing files were copied because they are needed for other tests that remained in flang/unittests/FortranEvaluate and for these 2 unit tests that I moved to flang-rt


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154869/new/

https://reviews.llvm.org/D154869