[libcxx-commits] [PATCH] D157171: [libc++] mdspan - implement layout_stride

Christian Trott via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 17 09:52:58 PDT 2023


crtrott marked an inline comment as done.
crtrott added inline comments.


================
Comment at: libcxx/test/std/containers/views/mdspan/layout_stride/ctor.default.pass.cpp:37
+  // check correct extents are returned
+  ASSERT_NOEXCEPT(m.extents());
+  assert(m.extents() == e);
----------------
philnik wrote:
> Please add a test to make sure `extents()` is const qualified. Also for `required_span_size()` and `strides()`.
Done in properties.pass.cpp


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157171/new/

https://reviews.llvm.org/D157171



More information about the libcxx-commits mailing list